Draft
Conversation
robertlong13
force-pushed
the
pr/dfreader_pandas
branch
from
5913725 to
b86415e
Compare
tridge
requested changes
May 20, 2025
Contributor
tridge
left a comment
tridge
left a comment
There was a problem hiding this comment.
i don't think this should be in top level
dfreader_pandas.py
Outdated
| @@ -0,0 +1,215 @@ | |||
| """ | |||
| Module to parse ArduPilot logs into pandas DataFrames with optional caching. | |||
Contributor
There was a problem hiding this comment.
should be in tools/ or examples/
Contributor
Author
There was a problem hiding this comment.
Yeah, it's out of place at top level for sure. I do want it to be importable though, like from pymavlink.tools.dfreader_pandas import parse_log_to_df. I'll figure out how to do that. I think that means I need to add tools to packages, which now that I say it, is probably better than installing all these tools as scripts. We should be calling them like python -m pymavlink.tools.magfit
Turns out I don't need to do anything, that can already be done
robertlong13
force-pushed
the
pr/dfreader_pandas
branch
3 times, most recently
from
52c6a8b to
58fda91
Compare
tridge
approved these changes
Jul 19, 2025
tridge
force-pushed
the
pr/dfreader_pandas
branch
from
ef4b093 to
6d7166f
Compare
Contributor
|
@robertlong13 looks good, just needs to be out of draft to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
I was tempted to make this as a totally separate repo, but maybe it's the right fit here. Opening a draft PR in case anyone else is interested in it.
This is handy for writing analysis scripts and jupyter notebooks. It resamples all your fields of interest to a common time base and returns everything together as a pandas dataframe. I also have it cache that dataframe so that you can quickly rerun your scripts during development without needing to handle caching manually.